Support mutiple management networks in systemvms by ravening · Pull Request #4678 · apache/cloudstack

ravening · 2021-02-10T15:37:19Z

Description

Currently only one management.network.cidr is suuported in systemvms
Allow supporting comma separated list of cidr's so that multiple
networks are reachable from systemvms.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

weizhouapache · 2021-02-10T20:11:51Z

+    cidrs=(${MGMTNET//,/ })
+    for cidr in ${cidrs[@]}
+    do
+      ip route add $cidr dev eth1


@ravening I am wondering why there is no "via gateway" in route.

@ravening I am wondering why there is no "via gateway" in route.

@ravening any update?

@ravening I am wondering why there is no "via gateway" in route.

@weizhouapache do we need the "via gateway" ? it was not there in the original change

@ravening the original line contained it (ip route add $MGMTNET via $LOCAL_GW dev eth1), can you explain why is removed?

yadvr · 2021-06-29T07:17:15Z

ping @ravening any update?

ravening · 2021-07-29T08:54:08Z

ping @ravening any update?

@rhtyd resolved conflicts

blueorangutan · 2021-07-29T11:18:02Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 687

blueorangutan · 2021-07-30T09:54:20Z

Trillian test result (tid-1414)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 74119 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4678-t1414-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 86 look OK, 3 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_invalid_upgrade_kubernetes_cluster	`Failure`	3612.97	test_kubernetes_clusters.py
test_02_deploy_and_upgrade_kubernetes_cluster	`Failure`	3611.12	test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	0.05	test_kubernetes_clusters.py
test_04_basic_lifecycle_kubernetes_cluster	`Failure`	0.05	test_kubernetes_clusters.py
test_05_delete_kubernetes_cluster	`Failure`	0.04	test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster	`Failure`	0.04	test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster	`Failure`	0.04	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	`Failure`	0.04	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	`Error`	93.19	test_kubernetes_clusters.py
test_04_create_template_with_checksum_md5	`Error`	65.66	test_templates.py
test_05_create_template_with_no_checksum	`Error`	65.60	test_templates.py
test_03_delete_template	`Error`	298.42	test_templates.py
test_09_list_templates_download_details	`Failure`	0.03	test_templates.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	`Failure`	544.01	test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics	`Failure`	366.70	test_vpc_redundant.py

sureshanaparti · 2021-07-30T13:01:06Z

@blueorangutan test

blueorangutan · 2021-07-30T13:02:03Z

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2021-07-31T03:09:53Z

Trillian test result (tid-1433)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 48772 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4678-t1433-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 86 look OK, 3 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_isolate_network_FW_PF_default_routes_egress_true	`Failure`	113.97	test_routers_network_ops.py
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true	`Failure`	392.58	test_routers_network_ops.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL	`Failure`	547.46	test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	`Failure`	465.35	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Failure`	560.92	test_vpc_redundant.py
test_01_redundant_vpc_site2site_vpn	`Failure`	361.02	test_vpc_vpn.py

yadvr · 2021-09-08T04:58:12Z

@blueorangutan package

blueorangutan · 2021-09-08T04:59:02Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-09-08T06:39:52Z

Packaging result: ✖️ el7 ✔️ el8 ✖️ debian ✔️ suse15. SL-JID 1163

DaanHoogland · 2021-09-14T14:36:56Z

@blueorangutan package

blueorangutan · 2021-09-14T14:38:04Z

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-09-14T15:28:27Z

Packaging result: ✔️ el7 ✖️ el8 ✔️ debian ✔️ suse15. SL-JID 1250

DaanHoogland · 2021-09-15T08:33:35Z

@blueorangutan package

blueorangutan · 2021-09-15T08:34:02Z

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-09-15T09:04:53Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1265

nvazquez · 2021-09-16T04:16:43Z

@blueorangutan test

blueorangutan · 2021-09-16T04:18:03Z

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2021-09-16T16:39:22Z

Trillian test result (tid-2079)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42682 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4678-t2079-kvm-centos7.zip
Smoke tests completed. 89 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

nvazquez · 2021-09-16T19:23:16Z

Ping @ravening can you check the open comment on the script file?

Currently only one management.network.cidr is suuported in systemvms Allow supporting comma separated list of cidr's so that multiple networks are reachable from systemvms.

ravening · 2021-09-29T09:36:40Z

Ping @ravening can you check the open comment on the script file?

@nvazquez @weizhouapache made the changes

nvazquez · 2022-02-18T02:48:08Z

@blueorangutan package

blueorangutan · 2022-02-18T02:49:03Z

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2022-02-18T03:48:30Z

Packaging result: ✖️ el7 ✖️ el8 ✔️ debian ✖️ suse15. SL-JID 2650

DaanHoogland · 2022-02-18T10:29:28Z

@blueorangutan package

blueorangutan · 2022-02-18T10:30:03Z

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2022-02-18T11:24:47Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2657

DaanHoogland · 2022-02-18T13:24:06Z

@blueorangutan test

blueorangutan · 2022-02-18T13:25:06Z

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-02-18T22:29:59Z

Trillian test result (tid-3390)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31258 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4678-t3390-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

weizhouapache

tested ok.

weizhouapache reviewed Feb 10, 2021

View reviewed changes

shwstppr added this to the 4.16.0.0 milestone Feb 15, 2021

ravening force-pushed the ssvm-multiple-network branch from 0465a2f to 2e22e7f Compare July 29, 2021 08:53

weizhouapache mentioned this pull request Sep 15, 2021

Console proxy timeouts when there are multiple subnets #5452

Closed

nvazquez added status:needs-testing type:enhancement labels Sep 16, 2021

nvazquez modified the milestones: 4.16.0.0, 4.17.0.0 Sep 26, 2021

ravening and others added 2 commits September 29, 2021 11:34

Support mutliple management networks in systemvms

66801d9

Currently only one management.network.cidr is suuported in systemvms Allow supporting comma separated list of cidr's so that multiple networks are reachable from systemvms.

add local gateway

b03498e

ravening force-pushed the ssvm-multiple-network branch from 2e22e7f to b03498e Compare September 29, 2021 09:36

weizhouapache self-assigned this Feb 21, 2022

weizhouapache approved these changes Feb 22, 2022

View reviewed changes

nvazquez approved these changes Feb 22, 2022

View reviewed changes

nvazquez removed the status:needs-testing label Feb 22, 2022

nvazquez merged commit 831f7cf into apache:main Feb 22, 2022

Conversation

ravening commented Feb 10, 2021

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

weizhouapache Feb 10, 2021

Choose a reason for hiding this comment

Uh oh!

sureshanaparti Jun 27, 2021

Choose a reason for hiding this comment

Uh oh!

ravening Jul 29, 2021

Choose a reason for hiding this comment

Uh oh!

nvazquez Sep 16, 2021

Choose a reason for hiding this comment

Uh oh!

yadvr commented Jun 29, 2021

Uh oh!

ravening commented Jul 29, 2021

Uh oh!

blueorangutan commented Jul 29, 2021

Uh oh!

blueorangutan commented Jul 30, 2021

Uh oh!

sureshanaparti commented Jul 30, 2021

Uh oh!

blueorangutan commented Jul 30, 2021

Uh oh!

blueorangutan commented Jul 31, 2021

Uh oh!

yadvr commented Sep 8, 2021

Uh oh!

blueorangutan commented Sep 8, 2021

Uh oh!

blueorangutan commented Sep 8, 2021

Uh oh!

DaanHoogland commented Sep 14, 2021

Uh oh!

blueorangutan commented Sep 14, 2021

Uh oh!

blueorangutan commented Sep 14, 2021

Uh oh!

DaanHoogland commented Sep 15, 2021

Uh oh!

blueorangutan commented Sep 15, 2021

Uh oh!

blueorangutan commented Sep 15, 2021

Uh oh!

nvazquez commented Sep 16, 2021

Uh oh!

blueorangutan commented Sep 16, 2021

Uh oh!

blueorangutan commented Sep 16, 2021

Uh oh!

nvazquez commented Sep 16, 2021

Uh oh!

ravening commented Sep 29, 2021

Uh oh!

nvazquez commented Feb 18, 2022

Uh oh!

blueorangutan commented Feb 18, 2022

Uh oh!

blueorangutan commented Feb 18, 2022

Uh oh!

DaanHoogland commented Feb 18, 2022

Uh oh!

blueorangutan commented Feb 18, 2022

Uh oh!

blueorangutan commented Feb 18, 2022

Uh oh!

DaanHoogland commented Feb 18, 2022

Uh oh!

blueorangutan commented Feb 18, 2022

Uh oh!